Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement QuoteStrategy on SqlWalker walkRangeVariableDeclaration #688

Merged
merged 4 commits into from Jun 12, 2013
Merged

Implement QuoteStrategy on SqlWalker walkRangeVariableDeclaration #688

merged 4 commits into from Jun 12, 2013

Conversation

johnbrown
Copy link

@FabioBatSilva
Copy link
Member

Could you add a test please ?
Something like this

Adding simple test to ensure quoting of table names still functions. …
9bea612 
…Note: the funtionality of this change won't be noticiable unless a custom quote strategy is implemented
@johnbrown
Copy link
Author

I added a simple test. However, the functionality should not change unless a custom QuoteStrategy is implemented.

@FabioBatSilva
Copy link
Member

You are right about the test.

Anyway, if you are interested,
there is two other points where you can replace the old quote API : L878 and L933

guilhermeblanco added a commit that referenced this pull request Jun 12, 2013
@guilhermeblanco
Merge pull request #688 from sellingsource/master
6ef4856 
Implement QuoteStrategy on SqlWalker walkRangeVariableDeclaration
@guilhermeblanco guilhermeblanco merged commit 6ef4856 into doctrine:master Jun 12, 2013
@doctrinebot doctrinebot mentioned this pull request Dec 6, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johnbrown @FabioBatSilva @guilhermeblanco